Re: [PATCH 2/4] gdbserver use aarch64_create_target_description

[Yao Qi <qiyaoltc at gmail dot com>]

Alan Hayward <Alan.Hayward@arm.com> writes:

Patch is good to me.  A nit below,

> +   srv_aarch64_linux_regobj="aarch64.o"
>  else
>     srv_i386_linux_regobj=""
>     srv_amd64_linux_regobj=""
> +   srv_aarch64_linux_regobj=""
>  fi

Can we avoid using a variable srv_aarch64_linux_regobj here?  Instead,
does the condition check $development somewhere below....

We have these variables for x86 because these variables are used
multiple times.  However, for aarch64, we don't have such uses.

>
>  ipa_ppc_linux_regobj="powerpc-32l-ipa.o powerpc-altivec32l-ipa.o powerpc-cell32l-ipa.o powerpc-vsx32l-ipa.o powerpc-isa205-32l-ipa.o powerpc-isa205-altivec32l-ipa.o powerpc-isa205-vsx32l-ipa.o powerpc-e500l-ipa.o powerpc-64l-ipa.o powerpc-altivec64l-ipa.o powerpc-cell64l-ipa.o powerpc-vsx64l-ipa.o powerpc-isa205-64l-ipa.o powerpc-isa205-altivec64l-ipa.o powerpc-isa205-vsx64l-ipa.o"
> @@ -50,13 +52,15 @@ srv_linux_obj="linux-low.o linux-osdata.o linux-procfs.o linux-ptrace.o linux-wa
>
>  case "${target}" in
>    aarch64*-*-linux*)
> -			srv_regobj="aarch64.o"
> +			srv_regobj="$srv_aarch64_linux_regobj"

... here, like this,
                        if $development; then
                           srv_regobj="aarch64.o"
                        else
                           srv_regobj=""
                        fi

>  			srv_regobj="${srv_regobj} arm-with-neon.o"
>  			srv_tgtobj="linux-aarch64-low.o aarch64-linux-hw-point.o"
>  			srv_tgtobj="$srv_tgtobj linux-aarch32-low.o"
>  			srv_tgtobj="${srv_tgtobj} arch/arm.o"
>  			srv_tgtobj="$srv_tgtobj aarch64-linux.o"
>  			srv_tgtobj="$srv_tgtobj arch/aarch64-insn.o"
> +			srv_tgtobj="$srv_tgtobj arch/aarch64.o"
> +			srv_tgtobj="$srv_tgtobj linux-aarch64-tdesc.o"
>  			srv_tgtobj="${srv_tgtobj} $srv_linux_obj"
>  			srv_xmlfiles="aarch64.xml"
>  			srv_xmlfiles="${srv_xmlfiles} aarch64-core.xml"

-- 
Yao (齐尧)