This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix type casts losing typedefs and reimplement "whatis" typedef stripping
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Simon Marchi <simark at simark dot ca>, GDB Patches <gdb-patches at sourceware dot org>, Phil Muldoon <pmuldoon at redhat dot com>
- Date: Mon, 20 Nov 2017 22:34:59 +0000
- Subject: Re: [PATCH] Fix type casts losing typedefs and reimplement "whatis" typedef stripping
- Authentication-results: sourceware.org; auth=none
- References: <1498837699-20897-1-git-send-email-palves@redhat.com> <d727c2c0-9e19-9e7e-c1c0-38b3345f0499@redhat.com> <5225ca30-ef69-040d-3f96-be2e5e87b80b@redhat.com> <CAH=s-PMc+bp7rXhwZ0kNdTc5WZ+xL0G1NSE6m3pMM_zFo60b6Q@mail.gmail.com> <4b73fb98-b8c2-9d2f-1981-4660e3c202e6@simark.ca> <67474590-af49-a387-9f8b-044bdd689dc7@redhat.com>
On 17-11-20 16:42:48, Pedro Alves wrote:
>
> So in that spirit, I propose starting my making the testcase adjust
> itself, like below, and also test floats of different sizes, leaving
> changing GDB's behavior for a separate consideration/change (using
> the fixed/extended test as baseline).
>
I agree. Some tests fail on 32-bit at the point when they were added,
so tests should match gdb's behaviour. As usual, we can gdb behaviour
after we are sure the behaviour is incorrect.
Beside Simon's review, patch is good to me.
--
Yao (齐尧)