This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Allow osabi to be optional in target descriptors
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Alan Hayward <Alan dot Hayward at arm dot com>
- Cc: "gdb-patches\@sourceware.org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
- Date: Thu, 16 Nov 2017 09:17:22 +0000
- Subject: Re: [PATCH] Allow osabi to be optional in target descriptors
- Authentication-results: sourceware.org; auth=none
- References: <D2781F20-8E87-4D21-8898-395B44496C51@arm.com>
Alan Hayward <Alan.Hayward@arm.com> writes:
Patch is good to me, some nits on commit log and code,
> Osabi is an option field in target descriptors, according to:
s/target descriptors/target descriptions/
> https://sourceware.org/gdb/current/onlinedocs/gdb/Target-Description-Format.html
>
> However, removing the osabi field from the i386 and amd64 target descriptors
Likewise.
>
> The following patch fixes this error.
>
> Tested with gdbserver on x86 and also on aarch64 with my target descriptor patch.
Likewise.
> @@ -105,9 +104,12 @@ tdesc_get_features_xml (target_desc *tdesc)
> buffer += tdesc->arch;
> buffer += "</architecture>";
>
> - buffer += "<osabi>";
> - buffer += tdesc->osabi;
> - buffer += "</osabi>";
> + if (tdesc->osabi != NULL)
As we are in C++, I prefer nullptr.
s/NULL/nullptr/
--
Yao (齐尧)