This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 30/40] Use search_domain::FUNCTIONS_DOMAIN when setting breakpoints
- From: Pedro Alves <palves at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 8 Nov 2017 16:20:17 +0000
- Subject: Re: [PATCH 30/40] Use search_domain::FUNCTIONS_DOMAIN when setting breakpoints
- Authentication-results: sourceware.org; auth=none
- References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-31-git-send-email-palves@redhat.com> <9b79fadc-9ad9-0b02-14c3-b63ff3803396@redhat.com>
On 08/08/2017 10:07 PM, Keith Seitz wrote:
> On 06/02/2017 05:22 AM, Pedro Alves wrote:
>
>> however, we're currently passing down search_domain::ALL_DOMAIN when
>> we know we're looking for functions, for no good reason. This patch
>> fixes that.
>
> I have a similar patch on the compile branch.
That one I had no idea... :-P
>
>> gdb/ChangeLog:
>> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>>
>> * linespec.c (iterate_over_all_matching_symtabs): Add
>> search_domain parameter. Pass it down to expand_symtabs_matching.
>> (decode_objc): Request FUNCTIONS_DOMAIN symbols only.
>> (lookup_prefix_sym): Adjust by passing ALL_DOMAIN as
>> search_domain.
>> (add_all_symbol_names_from_pspace): Add search_domain parameter.
>> Pass it down.
>> (find_method, find_function_symbols): Request FUNCTIONS_DOMAIN
>> symbols.
>> (add_matching_symbols_to_info): Add search_domain parameter. Pass
>> it down.
>
> LGTM
Thanks, pushed.
Pedro Alves