This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/4] Add aarch64_create_target_description


Alan Hayward <Alan.Hayward@arm.com> writes:

> +/* The Aarch64 target descriptor.  */

s/descriptor/description/

> +static const struct target_desc *aarch64_tdesc = NULL;
> +

Remove "struct".

Can you move aarch64_tdesc to aarch64_read_description?  I think it
only needs to be visible inside that function.

>  /* The standard register names, and all the valid aliases for them.  */
>  static const struct
>  {
> @@ -2827,6 +2830,19 @@ aarch64_displaced_step_hw_singlestep (struct gdbarch *gdbarch,
>    return 1;
>  }
>
> +/* Get the correct target description.  */
> +
> +const target_desc *
> +aarch64_read_description ()

Otherwise, the patch is good to me.

-- 
Yao (齐尧)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]