This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Opinion about -Wtautological-compare
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Mon, 30 Oct 2017 09:35:12 +0000
- Subject: Re: Opinion about -Wtautological-compare
- Authentication-results: sourceware.org; auth=none
- References: <f64bd46a-acb0-2031-d408-a331245e1fd5@ericsson.com>
On Sat, Oct 28, 2017 at 4:24 AM, Simon Marchi <simon.marchi@ericsson.com> wrote:
> Personally, I think the warning is useful and can reveal bugs, so I'd like to keep
> it. I lean towards 2 or 3, because they help convey the idea that we check if the
> value is within a range. If you are following with the architecture manual on the
> side, it will probably show the same range (0-3) for those bits, so it helps if the
> code does the same.
>
My vote is 3. PR 22188.
--
Yao (齐尧)