This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix faulty use of obstack_free() to shrink dont_print_statmem_obstack. Instead use obstack_blank_fast() with a "negative" size. A real stack data structured would be appropriate here. Added unit test gdb/testsuite/gdb.cp/printstaticrecursion.exp.

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: osscontribute <osscontribute at gmail dot com>
Cc: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
Date: Mon, 23 Oct 2017 16:06:58 -0400
Subject: Re: [PATCH] Fix faulty use of obstack_free() to *shrink* dont_print_statmem_obstack. Instead use obstack_blank_fast() with a "negative" size. A real stack data structured would be appropriate here. Added unit test gdb/testsuite/gdb.cp/printstaticrecursion.exp.
Authentication-results: sourceware.org; auth=none
References: <1508405381-16638-1-git-send-email-osscontribute@gmail.com> <a983ffc6-25d8-0553-3e4d-69dc3fec72df@ericsson.com> <0d612f89-a3a9-afea-965b-7c364b660235@ericsson.com> <6cc773d7-ee68-5f5c-46f4-cc4a044c9d3e@ericsson.com> <77217CC1-7D3D-431C-9B43-8EA3BE956827@gmail.com>

On 2017-10-23 15:55, osscontribute wrote:

The obstack_free() interface is pretty bad. It actually expects a
pointer to an existing base (of an object) and not a pointer in the
middle of a growing object.

Oops, I saw that reply too late. It would be nice if you could mentionthat in the commit log, for anyone in the future wondering why thatchange was made.


Thanks,

Simon

References:

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [PATCH] Fix faulty use of obstack_free() to *shrink* dont_print_statmem_obstack. Instead use obstack_blank_fast() with a "negative" size. A real stack data structured would be appropriate here. Added unit test gdb/testsuite/gdb.cp/printstaticrecursion.exp.

Re: [PATCH] Fix faulty use of obstack_free() to shrink dont_print_statmem_obstack. Instead use obstack_blank_fast() with a "negative" size. A real stack data structured would be appropriate here. Added unit test gdb/testsuite/gdb.cp/printstaticrecursion.exp.