This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA v4] enable/disable sub breakpoint range
On 10/23/2017 11:07 AM, Xavier Roirand wrote:
> Hello,
>
> Seems that my v3 patch sent in my previous email was not merging fine so
> here's a rebased version. Hope it will work better.
>
Hmm, I still get (against current master / f6af9f3428fa):
$ patch --dry-run -i patch.diff -p1
checking file gdb/NEWS
checking file gdb/breakpoint.c
Hunk #1 FAILED at 93.
Hunk #2 FAILED at 14160.
Hunk #3 FAILED at 14178.
Hunk #4 FAILED at 14222.
Hunk #6 FAILED at 14287.
Hunk #7 FAILED at 14396.
6 out of 7 hunks FAILED
checking file gdb/doc/gdb.texinfo
checking file gdb/testsuite/gdb.cp/locbprange.cc
checking file gdb/testsuite/gdb.cp/locbprange.exp
Not sure why... Does it work for you if you copy paste it from your
mail client?
There's a leading indentation in all lines in the commit log below which
suggests to me that you copy/pasted the patch from the output
of "git show"? A better way is to use "git format-patch -1" instead.
That makes it possible to use "git am" to import a patch.
Please can you try that, and send the result as an attachment.
[Please also look into git send-email for the future. It should
make things smoother. Joel uses that so I assume it wouldn't be
a problem on your server's end.]
> -----
>
> Allow enabling/disabling breakpoint location range
>
> In some cases, adding one breakpoint corresponds to multiple
> places in a program thus leads GDB to define main breakpoint
> number and other breakpoints using location number with syntax:
>
...
Thanks,
Pedro Alves