This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 3/3] Remove cleanups from break-catch-syscall.c

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Thu, 19 Oct 2017 15:57:14 -0600
Subject: Re: [RFA 3/3] Remove cleanups from break-catch-syscall.c
Authentication-results: sourceware.org; auth=none
References: <20171018040645.7212-1-tom@tromey.com> <20171018040645.7212-3-tom@tromey.com> <d82edff93309837942720f187905808a@polymtl.ca>

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> Maybe an opportunity to std::move?  Alternatively:
Simon>   holders.emplace_back (string_printf ("group:%s", group_ptr[i]));
Simon>   group_ptr[i] = holders.back ().c_str ();

I made this change.  Thanks for noticing this.

Tom

Follow-Ups:
- Re: [RFA 3/3] Remove cleanups from break-catch-syscall.c
  - From: Tom Tromey

References:
- [RFA 1/3] Remove cleanups from prepare_execute_command
  - From: Tom Tromey
- [RFA 3/3] Remove cleanups from break-catch-syscall.c
  - From: Tom Tromey
- Re: [RFA 3/3] Remove cleanups from break-catch-syscall.c
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]