This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] GDB test suite: Add helper for locating core files
- From: "Maciej W. Rozycki" <macro at mips dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>, Kevin Buettner <kevinb at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Tue, 17 Oct 2017 19:19:24 +0100
- Subject: Re: [PATCH 1/2] GDB test suite: Add helper for locating core files
- Authentication-results: sourceware.org; auth=none
- References: <1505760152-28775-1-git-send-email-arnez@linux.vnet.ibm.com> <1505760152-28775-2-git-send-email-arnez@linux.vnet.ibm.com> <20171007094545.1bba5c51@pinnacle.lan> <m31smcp3b6.fsf@oc1027705133.ibm.com> <b43a08e1-c79d-a4a6-662f-c2e21b150ec6@redhat.com>
On Tue, 17 Oct 2017, Pedro Alves wrote:
> >> E.g. when I test your patch on my x86-64 linux box using the
> >> following command...
> >>
> >> make check RUNTESTFLAGS="--target_board=native-gdbserver"
> >>
> >> ...I see 32 fewer passes than before and also one more known failure.
> >>
> >> Here are the passes that no longer occur when using your patch:
> >
> > [...]
> >
> >> Instead, several warnings are now printed instead:
> >>
> >> WARNING: Can not generate core dump on remote target.
> >
> > These warnings are newly introduced by the patch. They are meant to
> > improve diagnostics when someone attempts to run the tests on a "real"
> > remote target. I wanted to clearly document the fact that this is
> > unsupported (and always was). Also, by documenting this restriction,
> > maybe someone feels encouraged to lift it ;-)
>
> Wouldn't an UNTESTED or UNSUPPORTED be better? It's what
> we tend to do with other cases of unsupported/untested tests.
I think UNSUPPORTED is the right status; UNTESTED is meant for missing
tests really; see:
UNTESTED
A test was not run. This is a placeholder, used when there is no real
test case yet.
vs:
UNSUPPORTED
There is no support for the tested case. This may mean that a
conditional feature of an operating system, or of a compiler, is not
implemented. DejaGnu also uses this message when a testing
environment (often a "bare board" target) lacks basic support for
compiling or running the test case. For example, a test for the
system subroutine gethostname would never work on a target board
running only a boot monitor.
(taken from <http://www.delorie.com/gnu/docs/dejagnu/dejagnu_6.html>).
FWIW,
Maciej