Re: [PATCH 1/2] GDB test suite: Add helper for locating core files

[Pedro Alves <palves at redhat dot com>]

On 10/12/2017 05:47 PM, Pedro Alves wrote:
> On 10/12/2017 02:47 PM, Pedro Alves wrote:
>> On 10/09/2017 07:46 PM, Andreas Arnez wrote:
>>
>>> @@ -5883,7 +5883,7 @@ proc run_and_get_core {binfile {arg ""}} {
>>>  # specified.  Return that path name, or "" if no core file was found.
>>>  
>>>  proc find_core {binfile coredir {destcore ""}} {
>>> -    if {[is_remote target]} {
>>> +    if {![isnative]} {
>>>  	warning "Can not access remote core file."
>>>  	return ""
>>>      }
>>
>> This seems incorrect to me.  "isnative" only checks
>> if the build and target _triplets_ are the same.  So
>> foo-linux-gnu gdb x foo-linux-gnu gdbserver on separate
>> machine still returns isnative==true.
>>
>> I think the real problem is that the native-gdbserver board
>> returns true to is_remote, when I think it shouldn't.
>>
>> Doing that alone results in fallout in the testsuite, of
>> course.  I'm seeing if fixing it is doable.
> 
> It's doable.  Below's what I have.  This exposed a number of
> tests that were skipped for stale reasons.
> 
> The new "set cwd" command helps with this, which is nice
> in the "I love it when a plan comes together" sense.  :-)
> 
> I should probably split this up and submit in pieces.

FYI, this is now fully done and all pushed to master.
The native-gdbserver board no longer returns true
to [is_remote target].

Thanks,
Pedro Alves