This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 4/6] Simple cleanup removals in remote.c

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Simon Marchi <simon dot marchi at ericsson dot com>, Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Mon, 16 Oct 2017 17:00:36 -0600
Subject: Re: [RFA 4/6] Simple cleanup removals in remote.c
Authentication-results: sourceware.org; auth=none
References: <20171016030427.21349-1-tom@tromey.com> <20171016030427.21349-5-tom@tromey.com> <07804bc3-a6c5-2c0f-5730-5dd12fccafbe@ericsson.com> <87fuaipzgg.fsf@tromey.com> <b3aa8d31-e3f1-6e5d-233b-8779064ed157@ericsson.com> <97a40149-a30f-b2af-4441-6945b1d29cf1@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> This suggests to me that we're missing a string_printf variant
Pedro> that appends to a preexisting string:
Pedro>   void string_appendf (std::string &dest, const char* fmt, ...);
Pedro> See (untested) patch below.

Seems like a good idea FWIW.

Tom

Follow-Ups:
- [PATCH 1/2] Introduce string_appendf/string_vappendf (Re: [RFA 4/6] Simple cleanup removals in remote.c)
  - From: Pedro Alves
- [PATCH 2/2] remote.c, QCatchSyscalls: Build std::string instead of unique_xmalloc_ptr (Re: [RFA 4/6] Simple cleanup removals in remote.c)
  - From: Pedro Alves

References:
- [RFA 0/6] more cleanup removals
  - From: Tom Tromey
- [RFA 4/6] Simple cleanup removals in remote.c
  - From: Tom Tromey
- Re: [RFA 4/6] Simple cleanup removals in remote.c
  - From: Simon Marchi
- Re: [RFA 4/6] Simple cleanup removals in remote.c
  - From: Tom Tromey
- Re: [RFA 4/6] Simple cleanup removals in remote.c
  - From: Simon Marchi
- Re: [RFA 4/6] Simple cleanup removals in remote.c
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]