This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 4/7] Use ui_out_emit_tuple in disasm.c
- From: Tom Tromey <tom at tromey dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>, Simon Marchi <simon dot marchi at polymtl dot ca>, <gdb-patches at sourceware dot org>
- Date: Thu, 12 Oct 2017 15:07:27 -0600
- Subject: Re: [RFA 4/7] Use ui_out_emit_tuple in disasm.c
- Authentication-results: sourceware.org; auth=none
- References: <20170909153540.15008-1-tom@tromey.com> <20170909153540.15008-5-tom@tromey.com> <cf679537979e42ed7812a1361c902cd3@polymtl.ca> <79955c67-567b-7bc9-c238-9245c9ab1911@ericsson.com> <6226d3be-17c7-aa69-bdbf-efe11ffc1b5f@ericsson.com> <8760bkqrf4.fsf@tromey.com>
Tom> I think I'll just back out this particular change.
Tom> The way disasm code uses cleanups is very hard to untangle.
It turns out that with gdb::optional, you don't have to untangle it.
I'm testing a patch to convert the rest of disasm.c away from cleanups.
Tom