This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC][08/19] Target FP: Use target format throughout expression parsing
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 9 Oct 2017 14:12:15 -0400
- Subject: Re: [RFC][08/19] Target FP: Use target format throughout expression parsing
- Authentication-results: sourceware.org; auth=none
- References: <20170905182110.3ED3BD8086F@oc3748833570.ibm.com>
One C++ thing I did notice but forgot to report...
> +floatformat_from_string (const struct floatformat *fmt, gdb_byte *out,
> + std::string in)
Again, to be double-checked, but I think you want to pass the argument
by reference in this case. Otherwise, you may end up having an overhead
with might not be necessary due to the creation of a copy of the string
being passed as argument here.
--
Joel