This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC][08/19] Target FP: Use target format throughout expression parsing


One C++ thing I did notice but forgot to report...

> +floatformat_from_string (const struct floatformat *fmt, gdb_byte *out,
> +			 std::string in)

Again, to be double-checked, but I think you want to pass the argument
by reference in this case. Otherwise, you may end up having an overhead
with might not be necessary due to the creation of a copy of the string
being passed as argument here.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]