This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 02/12] Remove cleanup from display_gdb_prompt
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Thu, 28 Sep 2017 22:56:37 +0100
- Subject: Re: [RFA 02/12] Remove cleanup from display_gdb_prompt
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 72641356D3
- References: <20170928195011.27382-1-tom@tromey.com> <20170928195011.27382-3-tom@tromey.com>
Looks good, but ...
On 09/28/2017 08:50 PM, Tom Tromey wrote:
> /* Return the top level prompt, as specified by "set prompt", possibly
> @@ -428,7 +422,7 @@ display_gdb_prompt (const char *new_prompt)
> with the prompt prefix and suffix (annotations). The caller is
> responsible for freeing the returned string. */
... please remove that last sentence from the comment above.
>
> -static char *
> +static std::string
> top_level_prompt (void)
> {
Thanks,
Pedro Alves