Re: [RFA] Change exceptions.h functions to use gdb::function_view

[Tom Tromey <tom at tromey dot com>]

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> I'm borderline about this.  I have to say that I question the value of
Pedro> catch_exceptions&co, over just using TRY/CATCH + a scoped_restore(current_uiout)
Pedro> in the try scope + printing the exception.  A TRY/CATCH is likely to be
Pedro> easier to understand and debug, I think.
[...]
Pedro> Did you consider this?

Nope.  This was actually just a preparatory patch for another const change.

I can look into the change though.  I agree it would be better.

>> +         {
>> +	   return do_captured_thread_select (inner_uiout, tidstr);
>> +	 },

Pedro> Note the patch has several cases of tabs vs spaces like above.

Sorry about that.
Was there ever a decision about not using tabs?

In this case I think the problem is that Emacs isn't indenting lambdas
well.

Pedro> I don't think we need the casts nowadays.  catch_errors takes a const
Pedro> string (since the -Wwrite-strings patch).

Ok.

Tom