This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Remove ioctl-based procfs support on Solaris
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: John Baldwin <jhb at freebsd dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 27 Sep 2017 10:48:41 +0200
- Subject: Re: Remove ioctl-based procfs support on Solaris
- Authentication-results: sourceware.org; auth=none
- References: <yddy3p1vebc.fsf@CeBiTec.Uni-Bielefeld.DE> <5190367.sVyILAhGg6@ralph.baldwin.cx>
Hi John,
> FYI, bsd-kvm.c uses HAVE_SYS_USER_H and also uses _KMEMUSER (which your
> ChangeLog mentions, but I didn't see it removed in the configure.ac diff)
> bsd-kvm.c also uses <sys/proc.h> but it uses it unconditionally.
good catch. The bulk of patch was developed several months ago, and I
neglected to re-check every single detail. I've now restored the
sys/user.h check, which is really needed according to your comment.
The _KMEMUSER removal was mentioned in the ChangeLog because it was
present when I started the patch, but had been gone already in the
meantime.
Speaking of header guards, I noticed that HAVE_SYS_SYSCALL_H was still
present in config.in (and gdbserver/config.in) although I'd removed it
from configure.ac. Turned out that it crept back via common/common.m4.
Given that there are no more users, I've removed it there, too, and
regenerated the affected files (configure, config.in,
gdbserver/configure, gdbserver/config.in).
That's all in the incremental patch posted in response to Pedro's
comments.
Thanks for the heads-up.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University