This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH V2] dwarf2read: move producers help functions to a dwarf specific file
- From: Pedro Alves <palves at redhat dot com>
- To: Walfred Tedeschi <walfred dot tedeschi at intel dot com>, simon dot marchi at polymtl dot ca
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 26 Sep 2017 16:44:03 +0100
- Subject: Re: [PATCH V2] dwarf2read: move producers help functions to a dwarf specific file
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 685DCC0587E6
- References: <1506351078-5705-1-git-send-email-walfred.tedeschi@intel.com>
On 09/25/2017 03:51 PM, Walfred Tedeschi wrote:
> This patch add new files for the dwarf producer checks.
Not for the dwarf producer checks, but for the producer parsing.
Please update.
> +#include "defs.h"
> +#include "producer.h"
> +#include "utils.h"
> +
> +#if defined GDB_SELF_TEST
> +#include "selftest.h"
> +#endif
This "selftest.h" inclusion doesn't belong in this patch.
Please move it to the other patch, which actually adds the
selftests.
Otherwise OK. Please push (this patch) once fixed.
Thanks,
Pedro Alves