This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 1/5] Import "glob" and "getcwd" modules from gnulib
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Fri, 22 Sep 2017 12:01:36 +0100
- Subject: Re: [PATCH v3 1/5] Import "glob" and "getcwd" modules from gnulib
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D4424272C0
- References: <20170912042325.14927-1-sergiodj@redhat.com> <20170921225926.23132-1-sergiodj@redhat.com> <20170921225926.23132-2-sergiodj@redhat.com>
On 09/21/2017 11:59 PM, Sergio Durigan Junior wrote:
> * gnulib/import/m4/gnulib-cache.m4: Regenerate
Missing period.
> * ser-tcp.c: Undefine "close" before redefining it.
diff --git a/gdb/ser-tcp.c b/gdb/ser-tcp.c
index f35991c..c8be37b 100644
--- a/gdb/ser-tcp.c
+++ b/gdb/ser-tcp.c
@@ -42,6 +42,7 @@
> #ifndef ETIMEDOUT
> #define ETIMEDOUT WSAETIMEDOUT
> #endif
> +#undef close
> #define close(fd) closesocket (fd)
> #define ioctl ioctlsocket
> #else
Please add a comment. Something like:
/* Gnulib defines close too, but gnulib's replacement
doesn't call closesocket unless we import the
socketlib module. */
Otherwise OK.
Thanks,
Pedro Alves