This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] gdbserver: Move detach code to its own function
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Fri, 15 Sep 2017 15:12:58 +0100
- Subject: Re: [PATCH 2/2] gdbserver: Move detach code to its own function
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4CE284A703
- References: <1505482514-10206-1-git-send-email-simon.marchi@ericsson.com> <1505482514-10206-2-git-send-email-simon.marchi@ericsson.com>
On 09/15/2017 02:35 PM, Simon Marchi wrote:
> }
>
> +static void
> +handle_detach (char *own_buf)
> +{
Patch looks fine, but could you add some intro comment:
/* Handle the "D" packet. */
Thanks,
Pedro Alves