This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Make "list ambiguous" show symbol names too
- From: Keith Seitz <keiths at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 6 Sep 2017 11:42:54 -0700
- Subject: Re: [PATCH 2/2] Make "list ambiguous" show symbol names too
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=keiths at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 72BBEC04B92C
- References: <1504550858-27936-1-git-send-email-palves@redhat.com> <1504550858-27936-3-git-send-email-palves@redhat.com>
On 09/04/2017 11:47 AM, Pedro Alves wrote:
>
> Fix that by storing a pointer to the symbol in the sal.
:-)
> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * cli/cli-cmds.c (list_command): Use print_sal_location.
> (print_sal_location): New function.
> (ambiguous_line_spec): Use print_sal_location.
> * linespec.c (symbol_to_sal): Record the symbol in the sal.
> * symtab.c (find_function_start_sal): Likewise.
> * symtab.h (symtab_and_line::symbol): New field.
>
> gdb/testsuite/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * gdb.base/list-ambiguous.exp (test_list_ambiguous_symbol): Expect
> symbol names in gdb's output.
> * gdb.cp/overload.exp ("list all overloads"): Likewise.
FWIW, I looked this over and didn't see any problems.
Keith