This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Rename __BIT() to N32_BIT() in the nds32 target
- From: Pedro Alves <palves at redhat dot com>
- To: Kamil Rytarowski <n54 at gmx dot com>, jhb at freebsd dot org
- Cc: gdb-patches at sourceware dot org, binutils at sourceware dot org
- Date: Wed, 6 Sep 2017 18:11:47 +0100
- Subject: Re: [PATCH v2] Rename __BIT() to N32_BIT() in the nds32 target
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3AAF2461FA
- References: <20170905224019.18860-1-n54@gmx.com> <20170906151006.9169-1-n54@gmx.com>
On 09/06/2017 04:10 PM, Kamil Rytarowski wrote:
> The __BIT() macro used by the nds32 code conflicts with the NetBSD
> header <sys/cdefs.h> with a different __BIT() implementation,
> althought used for the same purpose.
>
> Remove the conflict with renaming __BIT() to N32_BIT().
This version's fine with me, thanks. I can't approve this though,
since opcodes/ is maintained by the binutils folks.
(It'd be nice to get this in quickly, because this issue
is blocking the NetBSD GDB bot, FWIW.)
Thanks,
Pedro Alves