This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, gdb/testsuite] Fix calls in gdb.arch/thumb2-it.exp
- From: Pedro Alves <palves at redhat dot com>
- To: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Wed, 6 Sep 2017 16:31:57 +0100
- Subject: Re: [PATCH, gdb/testsuite] Fix calls in gdb.arch/thumb2-it.exp
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 287E04E909
- References: <58a6af50-7bd9-f6c7-dbed-98c473e5e07d@foss.arm.com>
On 09/06/2017 04:26 PM, Thomas Preudhomme wrote:
> Hi,
>
> Tests in gdb.arch/thumb2-it.exp call functions defined in assembly
> without type debugging information. Since
> 7022349d5c86bae74b49225515f42d2e221bd368
I find Linux's style to refer to past commits helpful when
reading commit logs. I.e., also mention the commit subject, like:
... Since 7022349d5c86 ("Stop assuming no-debug-info functions
return int"), this triggers ...
This gives a clue to humans what the commit is about.
> this triggers an error which
> leads to many tests to FAIL. This patch cast the call to indicate the
> return type of the functions when calling them.
>
> Is this ok for master?
OK.
Thanks,
Pedro Alves