This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] eval.c:evaluate_subexp_standard: Factor out function call handling
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 5 Sep 2017 09:43:12 +0000
- Subject: Re: [PATCH] eval.c:evaluate_subexp_standard: Factor out function call handling
- Authentication-results: sourceware.org; auth=none
- References: <1504563210-2521-1-git-send-email-palves@redhat.com>
On 17-09-04 23:13:30, Pedro Alves wrote:
> While working on the no-debug-info debugging improvements, I found
> evaluate_subexp_standard's function call code unnecessarily long and
> hard to navigate and debug. The use of goto doesn't help either.
It is good to shorten the long function. Patch looks good to me.
> +/* Evaluate a function call. The function to be called is in
> + argvec[0]. FUNCTION_NAME is the name of the function, if known.
s/argvec/ARGVEC/ ?
and better to document that argvec[1] - argvec[nargs] are arguments
passed to the function.
--
Yao (齐尧)