This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/3] Add tests for loop_break and loop_continue commands


On 09/02/2017 10:36 PM, Simon Marchi wrote:
> I grepped the testsuite for loop_break and loop_continue and didn't find
> anything, so I wrote some simple tests for those.
> 
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.base/commands.exp: Call the new procedures.
> 	(loop_break_test, loop_continue_test): New procedures.

LGTM, please push, and thanks for doing this.

I do wonder whether we handle loop_break/loop_continue in nested
loops correctly though, since the tests don't seem to
exercise that.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]