This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] Add tests for loop_break and loop_continue commands
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Mon, 4 Sep 2017 13:36:11 +0100
- Subject: Re: [PATCH 3/3] Add tests for loop_break and loop_continue commands
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 518D43E2A1
- References: <1504388179-579-1-git-send-email-simon.marchi@ericsson.com> <1504388179-579-4-git-send-email-simon.marchi@ericsson.com>
On 09/02/2017 10:36 PM, Simon Marchi wrote:
> I grepped the testsuite for loop_break and loop_continue and didn't find
> anything, so I wrote some simple tests for those.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.base/commands.exp: Call the new procedures.
> (loop_break_test, loop_continue_test): New procedures.
LGTM, please push, and thanks for doing this.
I do wonder whether we handle loop_break/loop_continue in nested
loops correctly though, since the tests don't seem to
exercise that.
Thanks,
Pedro Alves