This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 3/3] Change counted_command_line to a shared_ptr

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Fri, 01 Sep 2017 22:48:45 +0200
Subject: Re: [RFA 3/3] Change counted_command_line to a shared_ptr
Authentication-results: sourceware.org; auth=none
References: <20170830220610.19718-1-tom@tromey.com> <20170830220610.19718-4-tom@tromey.com>

On 2017-08-31 00:06, Tom Tromey wrote:

This changes counted_command_line to be a typedef for std::shared_ptr
and removes the associated cleanups.  In the long run I believe that
cmd_list_element should also be changed to use a shared_ptr.

The command_line object is currently freed using free_command_lines.The shared_ptr will "delete" it. It seems to me that some C++ificationof the command_line structure needs to happen for it to get de-allocatedproperly.


Simon

Follow-Ups:
- Re: [RFA 3/3] Change counted_command_line to a shared_ptr
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]