This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 1/6] DWARF: Don't add nameless modules to partial symbol table.

From: Yao Qi <qiyaoltc at gmail dot com>
To: Tim Wiederhake <tim dot wiederhake at intel dot com>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Bernhard Heckel <bernhard dot heckel at intel dot com>
Date: Mon, 7 Aug 2017 23:07:58 +0100
Subject: Re: [PATCH v2 1/6] DWARF: Don't add nameless modules to partial symbol table.
Authentication-results: sourceware.org; auth=none
References: <1502098654-25203-1-git-send-email-tim.wiederhake@intel.com> <1502098654-25203-2-git-send-email-tim.wiederhake@intel.com>

On Mon, Aug 7, 2017 at 10:37 AM, Tim Wiederhake
<tim.wiederhake@intel.com> wrote:
> From: Bernhard Heckel <bernhard.heckel@intel.com>
>
> A name for BLOCK DATA in Fortran is optional.  If no name has been assigned,
> GDB will crash during read-in of DWARF when BLOCK DATA is represented via
> DW_TAG_module, e.g. as generated by ifort.  This patch fixes it.
>
> BLOCK DATA is used for one-time initialization of non-pointer variables in
> named common blocks.
>
> xxxx-yy-zz  Bernhard Heckel  <bernhard.heckel@intel.com>
>
> gdb/ChangeLog:
>         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
>
> gdb/testsuite/ChangeLog:
>         * gdb.fortran/block-data.f: New file.
>         * gdb.fortran/block-data.exp: New file.
>

Patch is good to me.

-- 
Yao (齐尧)

References:
- [PATCH v2 0/6] Some Fortran Patches
  - From: Tim Wiederhake
- [PATCH v2 1/6] DWARF: Don't add nameless modules to partial symbol table.
  - From: Tim Wiederhake

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]