Re: [PATCH] Fix dwarf2_string_attr for -gsplit-dwarf

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2017-08-02 12:56, Simon Marchi wrote:
> On 2017-08-02 12:12, Leszek Swirski via gdb-patches wrote:
> > > If you think this will be a one-time contribution, we can merge the 
> > > patch
> > > for you, and there is no need for copyright assignment for a simple 
> > > patch
> > > like that.  However, if you'd like to contribute further to GDB, we 
> > > can look
> > > into giving you write access, so you'll be able to push patches by 
> > > yourself.
> > > Let me know which one you prefer.
> >
> > Probably a one-off for now, this was pretty much just scratching an 
> > itch.
> > Anything that requires copyright assignment becomes more complicated 
> > for
> > obvious reasons if sent from my work account.
>
> Ok.
>
> > > The indentation for this line should be one tab + two spaces (like 
> > > the
> > > previous line).
> >
> > Yeah, I noticed that as soon as the email sent -- I had it right at 
> > one point,
> > but I guess I got bitten by `set expandtab` before sending. My bad.
> >
> > I'm assuming you don't need anything more from me to push?
>
> No, it should be fine.  I'll just leave this patch up for review for a
> few days in case somebody else wants to comment, and will push after
> that.
>
> Thanks,
>
> Simon

I have pushed this patch, thanks again.

I ran the tests with the "fission" board file and there were many tests 
that went from FAIL -> PASS.  So I concluded that we don't need to add a 
test specifically for this, but we should probably run the testsuite 
with the fission board on the buildbot.

Simon