This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING][PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode


On 2017-07-26 21:19, Ruslan Kabatsayev wrote:
So, the patch seems to have been approved by one reviewer (see [1]). But it doesn't appear to have been pushed, nor do I have any further instructions
on how to get it merged. What should I do?

Hi Ruslan,

The patch is fine with me too, it seems to work well and it's a good idea.

It might be a bit more work to implement (an idea for another patch maybe), but do you think it would be nice if n and s did next and step when focusing a source window, but did nexti and stepi when focusing an asm window? When in an asm window, I think you will much more likely want to use nexti/stepi than next/step, so maybe they should be bound to the n and s rather than N and S in that case?

In order to get the patch in, you have two choices: if you plan to contribute more in the future, we can get you write access to the repo, so that you can push your patches in once they are approved. Otherwise, we can push it for you. Let me know what you prefer.

Thanks,

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]