This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add enum for result of fast_tracepoint_collecting


Simon Marchi <simon.marchi@ericsson.com> writes:

>  /* Convenience wrapper.  Returns true if LWP is presently collecting a
>     fast tracepoint.  */
>  

The comments should be updated too.

> -static int
> +static fast_tpoint_collect_result
>  linux_fast_tracepoint_collecting (struct lwp_info *lwp,
>  				  struct fast_tpoint_collect_status *status)
>  {


> diff --git a/gdb/gdbserver/linux-low.h b/gdb/gdbserver/linux-low.h
> index 6328da0..18ca6a0 100644
> --- a/gdb/gdbserver/linux-low.h
> +++ b/gdb/gdbserver/linux-low.h
> @@ -26,6 +26,7 @@
>  /* Included for ptrace type definitions.  */
>  #include "nat/linux-ptrace.h"
>  #include "target/waitstatus.h" /* For enum target_stop_reason.  */
> +#include "tracepoint.h"
>  
>  #define PTRACE_XFER_TYPE long
>  
> @@ -358,7 +359,7 @@ struct lwp_info
>       return to the jump pad.  Normally, we won't care about this, but
>       we will if a signal arrives to this lwp while it is
>       collecting.  */
> -  int collecting_fast_tracepoint;
> +  fast_tpoint_collect_result collecting_fast_tracepoint;

The comments should be updated too.

>  
>    /* If this is non-zero, it points to a chain of signals which need
>       to be reported to GDB.  These were deferred because the thread

Otherwise, the patch is good to me.

-- 
Yao (齐尧)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]