Re: [PATCH v2] gdb.python/py-unwind: Disable stack protection

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2017-07-19 12:09, Yao Qi wrote:
> Simon Marchi <simon.marchi@ericsson.com> writes:
>
> > Maybe a better solution would be to change the test to make it cope 
> > with
> > different stack layouts (perhaps it could save addresses of stuff in
> > some global variables which GDB/the unwinder would read).  I'll go 
> > with
> > the simple solution for now though.
>
> I prefer moving this test to unit test, and the input is a series of
> instructions (copied from py-unwind.exe).  The unit test or self test 
> can
> somehow test python unwinder works as expected.

Ok, I take a note to try that eventually.

> > gdb/testsuite/ChangeLog:
> >
> > 	* gdb.python/py-unwind.exp: Disable stack protection when
> > 	building test file.
>
> The patch is good to me, but I think the test itself is still a little
> fragile.

Yes, it's still very fragile.  I'll push the current patch anyhow, since 
it fixes it for now.

Thanks,

Simon