This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add DISABLE_COPY_AND_ASSIGN
Pedro Alves <palves@redhat.com> writes:
> Yes, please. I've been meaning to add something like this for a while.
>
> IMO, this could go in include/ansidecl.h, with a fallback version for
> #if __cplusplus < C++11 that declares the methods without =delete (you
> get a link error instead).
>
I thought about adding this into include/, but can't find the right
file. I'll move the macro to include/ansidecl.h.
>> /* Pull in gdb::unique_xmalloc_ptr. */
>> #include "common/gdb_unique_ptr.h"
>>
>> +#define DISABLE_COPY_AND_ASSIGN(TYPE) \
>> + TYPE (const TYPE&) = delete; \
>> + void operator= (const TYPE &) = delete;
>> +
>
> Should this have an intro comment?
>
I thought it is too simple to have a comment :) How about this?
/* A macro to disable the copy constructor and assignment operator.
When building with C++ 11, explicitly delete these methods.
Otherwise, place this macro in the private: declarations of a class. */
#if __cplusplus >= 201103
#define DISABLE_COPY_AND_ASSIGN(TYPE) \
TYPE (const TYPE&) = delete; \
void operator= (const TYPE &) = delete;
#else
#define DISABLE_COPY_AND_ASSIGN(TYPE) \
TYPE (const TYPE&); \
void operator= (const TYPE &);
#endif /* __cplusplus >= 201103 */
>> --- a/gdb/common/refcounted-object.h
>> +++ b/gdb/common/refcounted-object.h
>> @@ -19,6 +19,8 @@
>> #ifndef REFCOUNTED_OBJECT_H
>> #define REFCOUNTED_OBJECT_H
>>
>> +#include "common-defs.h"
>> +
>
> This should not be necessary (and is against the guidelines [1]),
> since .c files must include defs.h/common-defs.h first thing. Why did
> you need it?
>
> [1]
> https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Include_Files
OK, good to know this link. Fixed.
--
Yao (齐尧)