This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] C++ify dwarf2_per_objfile
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: Trevor Saunders <tbsaunde at tbsaunde dot org>, gdb-patches at sourceware dot org
- Date: Mon, 17 Jul 2017 11:37:23 +0100
- Subject: Re: [PATCH] C++ify dwarf2_per_objfile
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3576C3DE3D
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3576C3DE3D
- References: <1500059913-6956-1-git-send-email-palves@redhat.com> <20170716174325.fmr33eerq2erbthc@ball> <e278e106-da16-6163-6ad2-9d03f7ed9693@redhat.com> <d0ec5cc24c6b3b0bc86538662e541a91@polymtl.ca>
On 07/17/2017 10:29 AM, Simon Marchi wrote:
> On 2017-07-16 22:07, Pedro Alves wrote:
>> Hi Trevor,
>> /* A set of CU "per_cu" pointer, DIE offset, and GDB type pointer.
>
> Looks good to me.
Thanks guys.
I pushed it, with a tiny change to also explicitly disable copy:
/* Disable copy. */
dwarf2_per_objfile (const dwarf2_per_objfile &) = delete;
void operator= (const dwarf2_per_objfile &) = delete;
I'm thinking that several functions in the file that work with
the "dwarf2_per_objfile" global might be candidates for
being struct dwarf2_per_objfile methods instead. But that's
for a rainy day.
Thanks,
Pedro Alves