This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Make "bt N" print correct number of frames when using a frame filter
- From: Tom Tromey <tom at tromey dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Fri, 14 Jul 2017 12:56:10 -0600
- Subject: Re: [RFA] Make "bt N" print correct number of frames when using a frame filter
- Authentication-results: sourceware.org; auth=none
- References: <20170423160446.17062-1-tom@tromey.com> <5aa8225f-70d1-2e69-9280-ca527b2ea981@redhat.com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> Can you expand on the need for the PRINT_MORE_FRAMES flag and
Pedro> having it based on from_tty? I assume that your first made
Pedro> the printing unconditional, but then for some reason decided
Pedro> against it?
I think my reason was just to have it parallel the no-frame-filter code
in stack.c:
/* If we've stopped before the end, mention that. */
if (fi && from_tty)
printf_filtered (_("(More stack frames follow...)\n"));
I don't know why this code is conditional on from_tty, but that seemed
like a separate decision.
Tom