This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 2/2] Remove BITS_IN_BYTES define
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Fri, 14 Jul 2017 16:16:22 +0100
- Subject: Re: [RFA 2/2] Remove BITS_IN_BYTES define
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 2F4013A8338
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2F4013A8338
- References: <20170713123400.28917-1-tom@tromey.com> <20170713123400.28917-3-tom@tromey.com>
On 07/13/2017 01:34 PM, Tom Tromey wrote:
> @@ -432,8 +432,8 @@ print_scalar_formatted (const gdb_byte *valaddr, struct type *type,
> case 'd':
> case 'u':
> {
> - bool is_signed = options->format != 'u' || !TYPE_UNSIGNED (type);
> - print_decimal_chars (stream, valaddr, len, is_signed, byte_order);
> + bool is_unsigned = options->format == 'u' || TYPE_UNSIGNED (type);
> + print_decimal_chars (stream, valaddr, len, !is_unsigned, byte_order);
> }
> break;
> case 0:
Ah, looks like you meant to squash this hunk in the previous patch...
The actual BITS_IN_BYTES bits are fine.
Thanks,
Pedro Alves