This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCHv2 2/2] gdb: Make some test names unique
- From: Pedro Alves <palves at redhat dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
- Cc: Yao Qi <qiyaoltc at gmail dot com>
- Date: Thu, 13 Jul 2017 23:40:40 +0100
- Subject: Re: [PATCHv2 2/2] gdb: Make some test names unique
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 28418C00576A
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 28418C00576A
- References: <cover.1497466455.git.andrew.burgess@embecosm.com> <c9b6ef063fbb5e33c157b1041418cd2fb7d8cf27.1497466455.git.andrew.burgess@embecosm.com> <20170713201511.GH27353@embecosm.com>
On 07/13/2017 09:15 PM, Andrew Burgess wrote:
> Thanks for the review and feedback. I've taken on-board what you both
> said, and I have a new patch which I think should be fine, in this I:
>
> - Add '(...text...)' at the end, but only _without_ a space before
> the '('.
>
> - I no longer use line numbers to make test names unique, instead I
> use more descriptive text.
>
> - I've not changed the names of any tests that were already unique,
> even if those names included a line number.
>
> OK to apply?
OK.
Though I'd think avoiding ()s entirely in the cases that the
()s are not part of the expression would be less surprising,
like e.g.:
-"evaluate filled vla(contents modified)"
+"evaluate filled vla, contents modified"
OK with that change too.
Thanks,
Pedro Alves