This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 02/10] Change backtrace_command_1 calling to use flags


On 04/25/2017 08:41 PM, Tom Tromey wrote:

> @@ -1891,7 +1889,7 @@ backtrace_command (char *arg, int from_tty)
>  	  if (subset_compare (this_arg, "no-filters"))
>  	    filters = false;
>  	  else if (subset_compare (this_arg, "full"))
> -	    fulltrace = true;
> +	    flags |= PRINT_LOCALS;
>  	  else
>  	    {
>  	      /* Not a recognized argument, so stop.  */
> @@ -1906,8 +1904,7 @@ backtrace_command (char *arg, int from_tty)
>  	arg = NULL;
>      }
>  
> -  backtrace_command_1 (arg, fulltrace /* show_locals */,
> -		       !filters /* no frame-filters */, from_tty);
> +  backtrace_command_1 (arg, flags, !filters /* no frame-filters */, from_tty);
>  }
>  

Looks fine.

(We should really make enum frame_filter_flags be an enum-flags.)

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]