This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 02/10] Change backtrace_command_1 calling to use flags
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Tue, 27 Jun 2017 17:29:35 +0100
- Subject: Re: [RFA 02/10] Change backtrace_command_1 calling to use flags
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com EC45EC04B946
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EC45EC04B946
- References: <20170425194113.17862-1-tom@tromey.com> <20170425194113.17862-3-tom@tromey.com>
On 04/25/2017 08:41 PM, Tom Tromey wrote:
> @@ -1891,7 +1889,7 @@ backtrace_command (char *arg, int from_tty)
> if (subset_compare (this_arg, "no-filters"))
> filters = false;
> else if (subset_compare (this_arg, "full"))
> - fulltrace = true;
> + flags |= PRINT_LOCALS;
> else
> {
> /* Not a recognized argument, so stop. */
> @@ -1906,8 +1904,7 @@ backtrace_command (char *arg, int from_tty)
> arg = NULL;
> }
>
> - backtrace_command_1 (arg, fulltrace /* show_locals */,
> - !filters /* no frame-filters */, from_tty);
> + backtrace_command_1 (arg, flags, !filters /* no frame-filters */, from_tty);
> }
>
Looks fine.
(We should really make enum frame_filter_flags be an enum-flags.)
Thanks,
Pedro Alves