This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix PR 21337 (v3): segfault when re-reading symbols with remote debugging.
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: Doug Gilmore <Doug dot Gilmore at imgtec dot com>
- Cc: Luis Machado <lgustavo at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Sun, 25 Jun 2017 13:24:57 +0200
- Subject: Re: [PATCH] Fix PR 21337 (v3): segfault when re-reading symbols with remote debugging.
- Authentication-results: sourceware.org; auth=none
- References: <d7619e0c-38f4-b547-8117-8e5315313b71@imgtec.com> <a869bc5c-a685-d9f1-1f28-aafcde8c3e1d@codesourcery.com> <20511c76-c816-d31d-5144-749eac9fc470@imgtec.com> <3c5ce0a0-72e5-4460-5555-ad2214866260@imgtec.com> <5c494cc147f71dd8246572aa0b815c9f@polymtl.ca> <fddf3219-1de7-09ca-517c-7d68b34e878d@imgtec.com> <7e9595026acbfd2f1a7bff321fa255e1@polymtl.ca> <d266f2a4-5482-6178-f4fd-9280e27757b4@imgtec.com> <5b5cc0a61e434a3406cbb25c16b8a550@polymtl.ca> <f6d52471-afdf-575f-488a-5ca9c2cb1158@imgtec.com> <e1620878165275e22429dbb746d40932@polymtl.ca> <f431263b-02f6-67f8-29df-753f367c2ebf@imgtec.com> <28fcce08-cab6-1e63-80d7-1d61c688cc10@imgtec.com> <09492e58ce0daf1efee14636bc5312cc@polymtl.ca> <5c33519c-6345-3cc8-2fa8-054a3b80bfb6@imgtec.com>
Hi Doug,
Good thing you pinged, I had completely missed it, sorry for the wait.
+gdb_test "source $gdbfile" ".*source-command-completed.*" \
+ "source $testfile.gdb"
+# Sometimes the failure only occurs on the second invocation.
+gdb_test "source $gdbfile" ".*source-command-completed.*" \
+ "source $testfile.gdb"
Tests should have unique names, so that when one fails, you know easily
which one. So, perhaps "source $testfile.gdb 1" and "source
$testfile.gdb 2"?
The patch is ok with this fixed.
Thanks,
Simon