This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 5/5] Add ATTRIBUTE_PRINTF to trace_start_error
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 14 Jun 2017 15:49:21 -0400
- Subject: Re: [PATCH 5/5] Add ATTRIBUTE_PRINTF to trace_start_error
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1906D4DD4B
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1906D4DD4B
- References: <1497124689-11842-1-git-send-email-simon.marchi@ericsson.com> <1497124689-11842-6-git-send-email-simon.marchi@ericsson.com>
On Saturday, June 10 2017, Simon Marchi wrote:
> clang complains that the fmt passed to vwarning in trace_start_error is
> not a literal. This looks like a fair warning, which can be removed by
> adding ATTRIBUTE_PRINTF to the declaration of trace_start_error.
>
> gdb/ChangeLog:
>
> * nat/fork-inferior.h (trace_start_error): Add ATTRIBUTE_PRINTF.
> ---
> gdb/nat/fork-inferior.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/nat/fork-inferior.h b/gdb/nat/fork-inferior.h
> index 10e3832..d369cff 100644
> --- a/gdb/nat/fork-inferior.h
> +++ b/gdb/nat/fork-inferior.h
> @@ -95,7 +95,7 @@ extern void gdb_flush_out_err ();
> (i.e., when the "traceme_fun" callback is called on fork_inferior)
> and bail out. This function does not return. */
> extern void trace_start_error (const char *fmt, ...)
> - ATTRIBUTE_NORETURN;
> + ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2);
>
> /* Like "trace_start_error", but the error message is constructed by
> combining STRING with the system error message for errno. This
> --
> 2.7.4
Thanks, this looks good to me.
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/