This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/5] Remove a few hurdles of compiling with clang


> From: Yao Qi <qiyaoltc@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,  Simon Marchi <simon.marchi@polymtl.ca>,  <gdb-patches@sourceware.org>, palves@redhat.com
> Date: Tue, 13 Jun 2017 16:21:54 +0100
> 
> Simon Marchi <simon.marchi@ericsson.com> writes:
> 
> > If somebody is willing to do the work and that it doesn't degrade the code quality,
> > we should have no problem accepting it.  So if it's a "side-step" that allows both
> > compilers to be happy, that's ok.  As a patch submitter, if you use primarily GCC,
> > you are not required to test your patches with Clang, but if you use primarily Clang,
> > you must test your patch with GCC (a version that's easily accessible for you).
> >
> > Does that sound like a good rule?
> 
> Yes, it is equivalent to "it is not acceptable to build GDB with
> compiler X but break  the build with GCC" in my last email.
> 
> I add some comments from Simon and Pedro.  Eli, is it good to you?

I believe I answered that some time ago.

Specifically, this text sounds too vague to me to be considered
"policy".  Too much is left to judgment calls.  But if everyone else
is happy, I won't insist on prolonging this discussion.

> I also looked for the place to add this policy.  Looks the most relevant
> page is https://sourceware.org/gdb/wiki/Internals%20Compiler-Warnings

I would suggest to consider a new page, or maybe make this part of
coding standards.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]