This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 01/25] Move initialize_tdesc_mips* calls from mips-linux-nat.c to mips-linux-tdep.c


On Mon, 12 Jun 2017, Yao Qi wrote:

> All target descriptions except mips initialization are called in -tdep.c,
> instead of -nat.c, so this patch moves mips target descriptions initialization
> to -tdep.c.  Secondly, I want to change the target descriptions from pre-generated
> to dynamical creation, so I want to test that these pre-generated target
> descriptions equal to these dynamically created ones.  Move target descriptions
> initialization to -tdep.c files so we can test them in any hosts (if they are
> still -nat.c, we can only test them on mips-linux host.).

 Can you please wrap the commit description such that it does not go past 
80th column?  Bear in mind that GIT indents by 4 characters, but if you 
stick to our general 74-column rule for text you'll be good.

 Otherwise LGTM.

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]