This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 10/23] Remove make_cleanup_restore_current_language
- From: Tom Tromey <tom at tromey dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Mon, 05 Jun 2017 07:09:31 -0600
- Subject: Re: [RFA 10/23] Remove make_cleanup_restore_current_language
- Authentication-results: sourceware.org; auth=none
- References: <20170503224626.2818-1-tom@tromey.com> <20170503224626.2818-11-tom@tromey.com> <3657014a-969e-dc93-298e-2e6f286ea425@redhat.com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> This is OK, but we may we want to take a closer look at
Pedro> terminology -- we started with scoped_restore, and have added
Pedro> other types called scoped_restore_whatever meanwhile.
Pedro> But here we're calling it "save". It seems to me like it may be
Pedro> better in the long run to pick one naming style for save/restore
Pedro> types, and stick with it.
I just went ahead and changed it to scoped_restore_language.
Tom