This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 13/23] Replace tui_restore_gdbout with scoped_restore
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Fri, 2 Jun 2017 19:34:53 +0100
- Subject: Re: [RFA 13/23] Replace tui_restore_gdbout with scoped_restore
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A461FC0587C3
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A461FC0587C3
- References: <20170503224626.2818-1-tom@tromey.com> <20170503224626.2818-14-tom@tromey.com>
On 05/03/2017 11:46 PM, Tom Tromey wrote:
> This patch replaces tui_restore_gdbout (a cleaup function) with a use
> of scoped_restore. This one is broken out into its own patch because
> it might slightly change the behavior of gdb: it saves and restores
> pagination_enabled, whereas the tui_restore_gdbout unconditionally set
> pagination_enabled to 1; and I think this warrants closer review.
>
> 2017-05-02 Tom Tromey <tom@tromey.com>
>
> * tui/tui-regs.c (tui_restore_gdbout): Remove.
> (tui_register_format): Use scoped_restore.
I think I ran into this in last year's console work (in an
earlier prototype.). It just looks bogus to me to
unconditionally enable pagination.
Patch is OK.
Thanks,
Pedro Alves