This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] sim: microblaze: target endianess recognition fix
- From: "Andrea Corallo via gdb-patches" <gdb-patches at sourceware dot org>
- To: GDB Patches <gdb-patches at sourceware dot org>
- Date: Fri, 2 Jun 2017 07:03:46 +0000 (UTC)
- Subject: Re: [PATCH] sim: microblaze: target endianess recognition fix
- Authentication-results: sourceware.org; auth=none
- References: <1063903693.5257056.1496148658168.ref@mail.yahoo.com> <1063903693.5257056.1496148658168@mail.yahoo.com> <592D910B.9040503@eagerm.com> <1701357949.5649512.1496160941429@mail.yahoo.com>
- Reply-to: Andrea Corallo <andrea_corallo at yahoo dot it>
- Reply-to: Andrea Corallo <andrea_corallo at yahoo dot it>
Hi Micheal,
re reading my last mail I've realized it was maybe not so clear.
I don't have write privileges so could you apply the patch?
Thanks Andrea
Il Martedì 30 Maggio 2017 18:16, Andrea Corallo via gdb-patches <gdb-patches@sourceware.org> ha scritto:
I guess I don't.
Thanks
K.
Il Martedì 30 Maggio 2017 17:34, Michael Eager <eager@eagerm.com> ha scritto:
On 05/30/2017 05:50 AM, Andrea Corallo via gdb-patches wrote:
> Hello,
> seams the microblaze simulator is missing endianness conversions running on small endian machine.
> This small patch does the job for me.
> I hope all is ok, is my first contribution so please forgive me in case I'm missing something.
>
> sim/microblaze/ChangeLog:
>
> 2017-05-30 Andrea Corallo <andrea_corallo@yahoo.it>
> * interp.c: (target_big_endian): target endianess recognition fix.
> ---
> sim/microblaze/interp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c
> index e619cf8..75fc98b 100644
> --- a/sim/microblaze/interp.c
> +++ b/sim/microblaze/interp.c
> @@ -31,7 +31,7 @@
>
> #include "microblaze-dis.h"
>
> -#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BIG_ENDIAN)
> +#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BFD_ENDIAN_BIG)
>
> static unsigned long
> microblaze_extract_unsigned_integer (unsigned char *addr, int len)
OK to apply. If you don't have write privileges, let me know.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077