This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix tui compilation with Solaris libcurses (PR tui/21482)

> From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
> Cc: gdb-patches@sourceware.org
> Date: Fri, 19 May 2017 14:50:06 +0200
> 
> I've checked in the cast part now.  Here's the NOMACROS part for
> gdb_curses.h.  Tested as before on sparcv9-sun-solaris2.10 (curses) and
> amd64-pc-solaris2.12 (ncurses).  Ok too?

I think this should be guarded by some OS-specific macro, so as not to
affect other platforms, where the original problem doesn't exist.  (I
see 6 instances of these macros being tested in my ncurses headers,
and I'm not on Solaris.)  Who knows what new problems this could cause?

Thanks.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]