This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 03/19] PR gdb/21226: Take DWARF stack value pieces from LSB end
Andreas Arnez <arnez@linux.vnet.ibm.com> writes:
>>> - const gdb_byte *val_bytes = value_contents_all (p->v.value);
>>> + /* Use zeroes if piece reaches beyond stack value. */
>>> + if (p->size > stack_value_size_bits)
>>> + break;
>>
>> Does this indicate something wrong in DWARF producer? Does GDB need to
>> emit a complaint?
>
> I don't know any DWARF producer that would emit such a DWARF piece.
> Whether it should be considered valid or not is unclear. Probably not.
> But if we emit a complaint for such a piece, then all pieces will become
> unusable just because GDB can't deal with that one piece. Before the
> change, no complaint was emitted either; not sure if the author had
> another reason for that.
Oh, I thought it is you who add this check and "break" in this patch. I
can't find such logic in the original code.
--
Yao (齐尧)