This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 02/12] btrace: Transfer ownership of pointers.

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Tim Wiederhake <tim dot wiederhake at intel dot com>
Cc: gdb-patches at sourceware dot org, markus dot t dot metzger at intel dot com
Date: Tue, 09 May 2017 08:21:53 -0400
Subject: Re: [PATCH v3 02/12] btrace: Transfer ownership of pointers.
Authentication-results: sourceware.org; auth=none
References: <1494312929-22749-1-git-send-email-tim.wiederhake@intel.com> <1494312929-22749-3-git-send-email-tim.wiederhake@intel.com>

On 2017-05-09 02:55, Tim Wiederhake wrote:

Directly insert new btrace_function pointers into the vector and havethevector own these pointers. This allows us to later retrieve theseobjects bytheir number directly after creation whereas at the moment we have towait
until the vector is fully populated.
This requires to pull btrace_thread_info through different functionsbut
cleans up the code for freeing the trace.


LGTM.

References:
- [PATCH v3 00/12] btrace: Turn linked list of function call segments into vector
  - From: Tim Wiederhake
- [PATCH v3 02/12] btrace: Transfer ownership of pointers.
  - From: Tim Wiederhake

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]