This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH obv] Remove some superfluous code in corelow.c


Pushed this as obvious.


In corelow.c I stumbled upon an extra semicolon and an xfree of a NULL
pointer.  Remove them.

gdb/ChangeLog:

	* corelow.c (sniff_core_bfd): Remove extra semicolon.
	(get_core_register_section): Remove xfree of NULL pointer.
---
 gdb/ChangeLog | 5 +++++
 gdb/corelow.c | 6 ++----
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4e278f5..de4d90f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2017-05-04  Andreas Arnez  <arnez@linux.vnet.ibm.com>
+
+	* corelow.c (sniff_core_bfd): Remove extra semicolon.
+	(get_core_register_section): Remove xfree of NULL pointer.
+
 2017-05-03  Alan Hayward  <alan.hayward@arm.com>
 
 	* frv-linux-tdep.c (frv_linux_supply_gregset): Use raw_supply_zeroed.
diff --git a/gdb/corelow.c b/gdb/corelow.c
index 3267c37..2266f24 100644
--- a/gdb/corelow.c
+++ b/gdb/corelow.c
@@ -129,7 +129,7 @@ sniff_core_bfd (bfd *abfd)
 {
   struct core_fns *cf;
   struct core_fns *yummy = NULL;
-  int matches = 0;;
+  int matches = 0;
 
   /* Don't sniff if we have support for register sets in
      CORE_GDBARCH.  */
@@ -511,7 +511,7 @@ get_core_register_section (struct regcache *regcache,
 			   const char *human_name,
 			   int required)
 {
-  static char *section_name = NULL;
+  static char *section_name;
   struct bfd_section *section;
   bfd_size_type size;
   char *contents;
@@ -519,8 +519,6 @@ get_core_register_section (struct regcache *regcache,
 				&& regset->flags & REGSET_VARIABLE_SIZE);
   ptid_t ptid = regcache_get_ptid (regcache);
 
-  xfree (section_name);
-
   if (ptid_get_lwp (ptid))
     section_name = xstrprintf ("%s/%ld", name,
 			       ptid_get_lwp (ptid));
-- 
2.5.0


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]