This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Only use 32-bit thumb-2 breakpoint instruction if necessary
- From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: Antoine Tremblay <antoine dot tremblay at ericsson dot com>, <gdb-patches at sourceware dot org>
- Date: Wed, 3 May 2017 07:55:09 -0400
- Subject: Re: [PATCH] Only use 32-bit thumb-2 breakpoint instruction if necessary
- Authentication-results: sourceware.org; auth=none
- Authentication-results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=ericsson.com;
- References: <1491936739-14649-1-git-send-email-antoine.tremblay@ericsson.com> <867f2ga303.fsf@gmail.com> <wwok37d2uc0h.fsf@ericsson.com> <86mvav6y30.fsf@gmail.com> <87fugmer1b.fsf@ericsson.com> <86wp9ybc3o.fsf@gmail.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Yao Qi writes:
> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>
>> Yes at first I though what's the harm in allowing different breakpoint
>> kinds on an address ?
>
> There is nothing harmful, IMO. It is a matter of complexity.
>
>>
>> But looking at the code that introduced the check there seems to be complex
>> reasons for that.
>>
>>>I would like to change GDBserver code, and fix the regressions caused
>>> by the change.
>>
>> I'm not sure what you mean ? You want to take over this issue ? (not a
>> problem with me)
>
> No, I have no plan to take this issue over. I mean, if I were you, I'd
> start from change GDBserver code, fix the regressions, etc.
>
>>
>> I think we may forget this change for 8.0 however... ?
>
> I feel it is difficult to catch 8.0 release, as there are still some open
> problems that we don't have ideas yet.
Since this won't be fixed for 8.0 and that I don't know when I will
rework on this, would it make sense to revert the software single step in
GDBServer ?
Basically as it is now software single step has problems in GDB and
GDBServer where as before 7.11 iirc at least GDBServer was working correctly.
Regards,
Antoine