This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 09/10] Class-ify lm_info_darwin
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Fri, 28 Apr 2017 17:00:35 +0100
- Subject: Re: [PATCH 09/10] Class-ify lm_info_darwin
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B5553C05AD6A
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B5553C05AD6A
- References: <20170426224706.27988-1-simon.marchi@ericsson.com> <20170426225139.313-9-simon.marchi@ericsson.com>
On 04/26/2017 11:51 PM, Simon Marchi wrote:
> This patch makes lm_info_darwin a "real" class. It initializes the
> field and replaces XCNEW/xfree with new/delete.
>
> I believe the cleanup in darwin_current_sos can be removed, I don't see
> anything that can throw after the allocation and the call to
> discard_cleanups.
Agreed.
LGTM but ...
> --- a/gdb/solib-darwin.c
> +++ b/gdb/solib-darwin.c
> @@ -41,6 +41,8 @@
> #include "mach-o.h"
> #include "mach-o/external.h"
>
> +#include <memory>
... this doesn't look necessary? (it was not in the ChangeLog.)
Thanks,
Pedro Alves